search

phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
11 stars 8 forks source link

Bounds for sensors aren't checked on initial drag #137

Closed phet-steele closed 7 years ago

phet-steele commented 7 years ago

During the "draggingTogether" phase for sensor tools (the initial drag out from the sensor tool box), the bounds of the tool are determined by the center of the main body. In other words, dragging towards the edge of the screen causes you to lose certain probes.

These are recoverable by changing zoom, changing window size, placing them back in the tool box and taking them back out, or pressing Reset All, but are otherwise lost forever. @samreid, could we add an additional bounds check/correction upon the initial release of a sensor (but only initial)? Unless you have a better idea.

cckdc15

Seen on macOS 10.12.6 Chrome. For phetsims/QA#33.

URL: http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.135/circuit-construction-kit-dc_en.html Version: 1.0.0-dev.135 2017-08-02 19:46:43 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36 Language: en-US Window: 1920x1012 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 32 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {"assert":{"sha":"928741cf","branch":"master"},"axon":{"sha":"0e3d5567","branch":"master"},"babel":{"sha":"51a4bd3b","branch":"master"},"brand":{"sha":"b630f897","branch":"master"},"chipper":{"sha":"6829432d","branch":"master"},"circuit-construction-kit-common":{"sha":"ee9efcbe","branch":"master"},"circuit-construction-kit-dc":{"sha":"5e5b0c9f","branch":"master"},"dot":{"sha":"f7d9de8b","branch":"master"},"joist":{"sha":"8a235835","branch":"master"},"kite":{"sha":"41ac3b7a","branch":"master"},"phet-core":{"sha":"d8bec6c1","branch":"master"},"phetcommon":{"sha":"7ec5d299","branch":"master"},"query-string-machine":{"sha":"c74e454e","branch":"master"},"scenery":{"sha":"9f5612d2","branch":"master"},"scenery-phet":{"sha":"23839a28","branch":"master"},"sherpa":{"sha":"be8e800b","branch":"master"},"sun":{"sha":"a56ba571","branch":"master"},"tandem":{"sha":"29cd4f63","branch":"master"},"twixt":{"sha":"3ca102d0","branch":"master"}}

samreid commented 7 years ago

Proposed fix is http://www.colorado.edu/physics/phet/dev/html/circuit-construction-kit-dc/1.0.0-dev.152/circuit-construction-kit-dc_en.html

@phet-steele can you please take a look?

phet-steele commented 7 years ago

Extraordinary!