search

phetsims / circuit-construction-kit-dc

"Circuit Construction Kit: DC" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
11 stars 8 forks source link

Light bulb not catching on fire #148

Closed samreid closed 7 years ago

samreid commented 7 years ago

Is it supposed to?

samreid commented 7 years ago

@arouinfar do you recall?

arouinfar commented 7 years ago

@samreid we discussed this a bit in https://github.com/phetsims/circuit-construction-kit-common/issues/72, and decided against having the light bulb catch fire.

@ariel-phet commented:

@samreid I think keeping the lightbulb flames would be problematic. A resistor only heats up if it has resistance (P=I^2*R). So The battery is being short circuited, and probably assumed to have some small internal resistance, but if you are setting the lightbulb to no resistance, it should actually not get hot.

samreid commented 7 years ago

But is that statement only for a 0-resistance light bulb?

arouinfar commented 7 years ago

Possibly... but it was in response to your comment asking if lightbulbs should catch fire.

The current behavior matches Java, and personally, I think a fiery bulb looks really strange. In interviews, students interpreted the fire just fine, so I'm not inclined to change it.

samreid commented 7 years ago

OK thanks! I'll finish removing the light bulb fire code.

samreid commented 7 years ago

Removed light bulb fire code, closing.