phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Snap Velocity? #102

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

From the design doc:

Velocity snaps to 1 degree, magnitude snappy 5 might be too restrictive to precisely point velocities 1 might be a more natural snapping increment, but could be harder to control. Let’s try 1 to start, but be open-minded if it’s too challenging to adjust -- perhaps bump it up to 2 or 5*.

This decision was made a long time ago. I'm a little reluctant to go ahead and implement this. If a user types in a value in the Keypad with 'More Data' on that makes the velocity's angle not a multiple of 1*, what happens? Assigning @arouinfar for comment.

brandonLi8 commented 4 years ago

Spoke with @arouinfar 6/25/20 and it was decided to not snap the velocity but to limit its x and y magnitude to 4 m/s (similar to how it is bounded in the keypad). 4 m/s can be changed later for all velocity manipulators.

Implementing this now.

brandonLi8 commented 4 years ago

Done in the commit above. Closing.