phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Rethink decision to use vector arrows. #104

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

From https://github.com/phetsims/collision-lab/issues/93.

At the recommendation of @pixelzoom:

I'd recommend explaining the problem to your design team, and seeing if you can come up with a design that separates the vector symbols from translated strings.

Here is the problem

The vector symbols for both of the locations will need to be translatable (at the very least the control panel). I anticipate some RTL languages might have the parenthesis before.

So this case is very different from Vector Addition, which uses a scenery Node to place an arrow on top of a single character, and combines multiple Text instances together. This approach wont work for collision lab.

I don't even want to get close to FormulaNode again. See https://github.com/phetsims/scenery/issues/457#issuecomment-526325443.

HTML entities also don't work because they don't work on all platforms, as described in #93.


I've been thinking about this more, and I'm not quite sure how we arrived at this decision. It seems like phet sims don't traditionally add a symbol in the control panels.

Like for instance, in masses in springs: image

or in gravity and orbits: image there isn't a separate label.

One justification for this comes from the design doc:

This will help serve has a key for the Values strings which reference just v & p.

I think that if this was concern, this can be done without the arrow symbol, ie. 'Velocity (v)'.

I agree that the change in momentum checkbox looks uglier image

But I think we can change this string to "Change in Momentum" image

arouinfar commented 4 years ago

@brandonLi8 thanks for describing the issue. I do not think the abbreviation/vector symbols are necessary, so let's simplify things and go with your last suggestion:

But I think we can change this string to "Change in Momentum" image

brandonLi8 commented 4 years ago

Thanks @arouinfar. This is done in master. Closing.