phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Branch: CompositeStuckBalls #107

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

From #87,

I said:

This makes me think that it might be better to add the 2 balls to a data structure that represents the 2 stuck balls.

I'm trying this in this branch.

brandonLi8 commented 4 years ago

In https://github.com/phetsims/collision-lab/issues/87#issuecomment-647045167, I've outlined some questions before merging this into master.

However, there are still some implementation details to cover as well.

Some other names to consider:

InelasticRotationEngine
InelasticRotationsEngine
StuckBallsCluster
StickyBallsRotator
StickyBallsHandler
StickyBallPairHandler
StickyBallPair

Ended up going with both StickyBallCluster and InelasticRotationEngine.

brandonLi8 commented 4 years ago

I think at this point, this branch can be merged to master. Doing that now.

brandonLi8 commented 4 years ago

Done. Closing.