phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Inelastic screen #114

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

I've already gotten a good start to the Inelastic screen in master. But there is still some design work:

brandonLi8 commented 4 years ago

Another question. What exactly happens when the user changes a preset. Here's the current behavior (based off my solar system):

brandonLi8 commented 4 years ago

I asked:

  • Where will the combo box that selects different presets be located. In master, I've thrown it in a random spot.
  • What will the names be for the different presets, and what are the different presets? In master, I have 'Custom', and two temporary names.
  • What's the title string of the presets (if we need one). Currently, I have it labeled as 'Presets'

In the design meeting, we decided to go with radio buttons instead. I've implemented it in master and it looks like image

which handles the placement and removes the need for title strings, so these questions have been answered.

I also asked:

  • Is there anything else in other screens that shouldn't be in this screen? (paths, values, etc.)

Based on the design meeting, the current version of the 'Inelastic' screen looks good.

I also asked:

  • What are we doing with the elasticity slider? Are we removing it or should we disable it? ...

We decided at the design meeting to make the control panel look like

image

doing this now.

brandonLi8 commented 4 years ago

Done in the commit above. The control panel now looks like

image

Closing.