search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

CT false is not a function #115

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago 
collision-lab : fuzz : built
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000
Query: fuzz&memoryLimit=1000
Uncaught TypeError: false is not a function
TypeError: false is not a function
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:1193686
at i.value (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:73174)
at new i (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:1193658)
at i.value (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:1197629)
at new t (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:1011941)
at i.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:2745)
at new i (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:1197538)
at i.createModel (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:1216787)
at initializeModel (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:794695)
at Array.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593597506167%7D&fuzz&memoryLimit=1000:945:985622)
id: Bayes Chrome
Snapshot from 7/1/2020, 3:20:48 AM

----------------------------------

collision-lab : fuzz : built
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000
Query: fuzz&memoryLimit=1000
Uncaught TypeError: false is not a function
TypeError: false is not a function
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:1193686
at i.value (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:73174)
at new i (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:1193658)
at i.value (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:1197629)
at new t (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:1011941)
at i.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:2745)
at new i (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:1197538)
at i.createModel (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:1216787)
at initializeModel (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:794695)
at Array.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593604271626%7D&fuzz&memoryLimit=1000:945:985622)
id: Bayes Chrome
Snapshot from 7/1/2020, 3:20:48 AM

----------------------------------

collision-lab : fuzz : built
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000
Query: fuzz&memoryLimit=1000
Uncaught TypeError: false is not a function
TypeError: false is not a function
at https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:1193686
at i.value (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:73174)
at new i (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:1193658)
at i.value (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:1197629)
at new t (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:1011941)
at i.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:2745)
at new i (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:1197538)
at i.createModel (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:1216787)
at initializeModel (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:794695)
at Array.<anonymous> (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1593595248373/collision-lab/build/phet/collision-lab_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22collision-lab%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1593595248373%22%2C%22timestamp%22%3A1593612890416%7D&fuzz&memoryLimit=1000:945:985622)
id: Bayes Chrome
Snapshot from 7/1/2020, 3:20:48 AM
brandonLi8 commented 4 years ago

This is a strange one.

The unbuilt version of collision lab is passing in CT, but the built version is failing.

brandonLi8 commented 4 years ago

Fixed in the commit above. I verified locally that the built version works. Closing.