search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Issues with Inelastic collisions #139

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

For phetsims/QA#524.

So far, perfectly elastic collisions are working well and I haven't found any bugs (testing on master). I have found a few cases that were incorrect when the elasticity wasn't 100%, particularly when a stack of balls collides with the border.

Example: ![*](https://user-images.githubusercontent.com/42391580/89325549-34327c00-d646-11ea-9262-b99b5912758d.gif)
brandonLi8 commented 4 years ago

This should be fixed in the commits above. I tested the exact same collision in the commit above and found no errors. I also tested all the other scenarios that I found that were broken and they all work fine. This could introduce new bugs. Closing.