phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Updates to default ball data #141

Closed arouinfar closed 4 years ago

arouinfar commented 4 years ago

For https://github.com/phetsims/QA/issues/529

I'd like to suggest a few tweaks to the default ball data.

The first two tweaks to ball positions will get rid of the overlapping velocity vectors, which I think looks nicer for an initial setup. The adjustment to Ball 3's initial velocity will make the first few collisions a bit more exciting. Currently, the balls tend to end up bouncing between the top and bottom walls.

Before After
Collision Lab screenshot (5) Collision Lab screenshot (6)
Collision Lab screenshot (8) Collision Lab screenshot (7)
Collision Lab screenshot (9) Collision Lab screenshot (10)
brandonLi8 commented 4 years ago

Done in the commit above. Closing.

arouinfar commented 4 years ago

It looks like the Intro screen defaults were reverted at some point. @jonathanolson can you update Ball's 2 initial position on the Intro screen to (1, 0)?

jonathanolson commented 4 years ago

Should be done, can you verify? (I also figured we'd want to keep the home-screen icon the same, let me know if you want it updated, it was linked in the code).

arouinfar commented 4 years ago

Looks good in master, @jonathanolson. Let's leave the Intro Screen icon as-is.