phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Review ?showPointerAreas #142

Closed ariel-phet closed 4 years ago

ariel-phet commented 4 years ago

@brandonLi8 it would be good to review ?showPointerAreas and likely expand a few "touch areas" where possible

For instance, the "reset collisions" button could have a dilated touch area, and I think if possible it would be good to expand the "More Data" checkbox touch area and such.

Could you take a first pass at this and then assign @arouinfar and I to review?

brandonLi8 commented 4 years ago

I did all of the suggestions in the commit above. Assigning @arouinfar and @ariel-phet for review.

brandonLi8 commented 4 years ago

Spoke with @ariel-phet on zoom. Pointer areas look good except for the number of balls number picker and the mass sliders, where this is some vertical overlap in pointer areas. Addressing that now.

arouinfar commented 4 years ago

@brandonLi8 the pointer areas are generally looking good to me. The only device I can test touch areas on is my phone, which I can do if you publish a dev version (no VPN to access master on my phone).

brandonLi8 commented 4 years ago

Overlap removed in the commit above. @ariel-phet @arouinfar please review in https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.1/phet/collision-lab_en_phet.html

ariel-phet commented 4 years ago

@brandonLi8 I reviewed on my phone. All looking quite good but I do have 2 requested tweaks:

  1. Increase the "reset collisions" touch area a bit more (until it touches the reflecting border)
  2. Dilate the zoom in/out button touch areas for the momentum diagram
brandonLi8 commented 4 years ago

Done in the commit above.

Restart Button:

image

Momenta Diagram: image

@ariel-phet @arouinfar please review in https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.3/phet/collision-lab_en_phet.htm

ariel-phet commented 4 years ago

All looks good. Closing!