phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Should PhetColorScheme be updated? #148

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

From the CRC:

  • [ ] Is PhetColorScheme used where appropriate? Verify that the sim is not inventing/creating its own colors for things that have been standardized in

I marked this as failing for now. I took a look at PhetColorScheme, and there are 3 things that could potentially be updated.

  1. According to PhetColorScheme, acceleration is green. Luckily, there are 0 usages of this! My recommendation would be to change this to yellow and update sims like projectile motion and collision lab (and others?) to use this constant.

  2. According to PhetColorScheme, velocity is red-colorblind. Luckily, there are 0 usages of this! My recommendation would be to change this to green and update sims like projectile motion and collision lab (and others?) to use this constant.

  3. There is no momentum in PhetColorScheme. We should probably add momentum using the color that collision lab is using.

@arouinfar @ariel-phet should I proceed with this?

ariel-phet commented 4 years ago

@brandonLi8 yes go ahead and make this change

arouinfar commented 4 years ago

@brandonLi8 I opened an issue in scenery-phet to track these changes.

jonathanolson commented 4 years ago

Should be good in master, @arouinfar can you verify?

arouinfar commented 4 years ago

Looks good in master. Thanks @jonathanolson.