phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

User reported issue: collide ball outside of reflecting border #150

Closed oliver-phet closed 3 years ago

oliver-phet commented 4 years ago

Reported via phethelp, reproduced using various conditions:

image
  1. Explore 1D
  2. Max/min balls
  3. Position A -.5, velocity .5m/s
  4. Position B 0, velocity .5m/s
  5. Elasticity to 90% (various issues occur at any value <100%)

I'm noticing a lot of weird issues that may be unrelated to reflecting border and seem to show up when Mass B >= 2.8kg

Name: ‪Collision Lab‬ URL: https://phet.colorado.edu/sims/html/collision-lab/latest/collision-lab_en.html Version: 1.0.1 2020-08-14 18:19:15 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.2 Safari/605.1.15 Language: en Window: 1680x987 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.20) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 15 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 16) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}

brandonLi8 commented 4 years ago

I'll investigate.

brandonLi8 commented 4 years ago

Tested the exact same setup on master. No issues found.

sample (master) ![*](https://user-images.githubusercontent.com/42391580/90815690-5257d780-e2e8-11ea-9d91-b275304009de.gif)

Then tested the setup on https://phet.colorado.edu/sims/html/collision-lab/latest/collision-lab_en.html and the problem is there.

sample (deployed prototype) ![*](https://user-images.githubusercontent.com/42391580/90816105-f9d50a00-e2e8-11ea-946b-fa344f95e179.gif)

A lot of things changed since the prototype was deployed in #126. Looks like this fixed itself!

brandonLi8 commented 4 years ago

@oliver-phet, @arouinfar what should we do from here. I confirmed that this is no longer a bug. Do we let the user know? Re-deploy another prototype? Or close and move forwards for the first "production" (non-prototype) version?

oliver-phet commented 4 years ago

I'll email the user either way.

arouinfar commented 4 years ago

@brandonLi8 if master is in a good state, I think we should redeploy the prototype.

arouinfar commented 4 years ago

@brandonLi8 actually, we can wait to redeploy until testing in https://github.com/phetsims/QA/issues/537 wraps up.

KatieWoe commented 3 years ago

Using described set up, did not see this in 1.1.0 dev.13. Will reopen if something else seems to happen that is similar.