search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Enable supportsZoom #151

Closed ariel-phet closed 4 years ago

ariel-phet commented 4 years ago

@brandonLi8 @arouinfar I tested this sim out with ?supportsZoom=true on my phone, and I think it would be particularly useful for this sim if used on a phone when doing number entry for any of the "more data" values. Ideally we are enabling this feature for all sims going forward, but we want to check that the UI is playing nicely. In my testing it all seemed to look good, so we should go ahead and enable it within the code.

@arouinfar assigning you in case you have any objections.

brandonLi8 commented 4 years ago

Added supportsZoom: true in the commit above. You can test it in https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.4/phet/collision-lab_en_phet.html

ariel-phet commented 4 years ago

Looking good!

@arouinfar please close if you agree, and keep in mind for publication!

arouinfar commented 4 years ago

This is super nice on mobile. Let's keep it and see what happens in QA.