search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

performance sign-off #157

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

This is listed as a "standard GitHub issue" in the code-review checklist. The lead designer must sign off on performance.

arouinfar commented 4 years ago

There are not any performance issues on my older MacBook Pro, but I don't have access to our usual test devices. I believe @ariel-phet has done some testing on lower performing devices, so I'll defer to him for the sign-off.

ariel-phet commented 4 years ago

@jonathanolson let me know when you a version to test with performance enhancements.

jonathanolson commented 4 years ago

Can you try out https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.7/phet/collision-lab_en_phet.html to see how the performance is? Also there may be some room for optimization on the "paths" view, since it's creating a large number of data points that are ALL being drawn EVERY frame. It would require a lot more complexity to optimize, so I wouldn't want to do that prematurely.

ariel-phet commented 4 years ago

@jonathanolson looking on iPad Air 2 iOS 14.0.1 things are looking solid (with 4 balls going, paths on, momenta diagram, and "more data" frame rate around 40 fps and looks acceptable. My home desktop stays solidly at 60 fps with these same options all active. I think we can go ahead with performance sign off here.