Some pixel polishes - Githubissues

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

6 stars 4 forks source link

Some pixel polishes #158

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

Discussed some pixel polishes with @ariel-phet on zoom today.

[x] Change the font for the velocity/momentum readouts on top of the balls and COM to 14.
[x] Change the vertical spacing between the momentum vectors in the momenta diagram to 0.5 for 1D screens.
[x] Remove the furthest zoom level (all the way zoomed out) for the momenta diagram (all screens).
[x] Change the default to one more level zoomed in (all screens).
[x] Add one more level of zoom-in (all screens).

brandonLi8 commented 4 years ago

Done in the commits above.

Assigning @ariel-phet to review in https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.5/phet/collision-lab_en_phet.html

FYI @ariel-phet @arouinfar I added the ?momentaDiagram1DSpacing query parameter (default is 0.5) to control the vertical spacing between the vectors in 1D screens.

arouinfar commented 4 years ago

Looks nice in master @brandonLi8.

ariel-phet commented 4 years ago

I did have one further request, to keep a constant vertical spacing (in terms of pixels) between the momenta vectors on the intro and explore 1d screens. @brandonLi8 is going to make a separate issue for that work. Closing this one, since everything that was requested was done!