phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Review the migration from AxonArray to createObservableArray #173

Closed samreid closed 4 years ago

samreid commented 4 years ago

In https://github.com/phetsims/axon/issues/335 we migrated AxonArray => createObservableArray (which uses the Proxy). It looks OK on my side and is passing fuzzing, but I thought it would be a good idea to request a review, since I am not familiar with the sim. Assigning to the responsible-dev.

jonathanolson commented 4 years ago

Looks good to me, thanks!