search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Buffering between toolbox and reset all button #181

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

Test device iPad 6th Gen Operating System iPadOS 14.1 Browser Safari Problem description For https://github.com/phetsims/QA/issues/562 On the iPad, in both landscape and portrait mode, the momenta diagram box overlaps with the reset all button on the Explore 2D screen.

Visuals IMG_0009

jonathanolson commented 3 years ago

@arouinfar do you have a preferred way of handling this? It WOULD be possible to reduce spacing/padding in the general case. However my preference would be to consider shrinking the Momenta Diagram to fit (which may take a big more logic internally). Thoughts?

arouinfar commented 3 years ago

This is super frustrating, and is something that QA has seen in several recent tests. For example: https://github.com/phetsims/energy-skate-park/issues/302, https://github.com/phetsims/build-a-molecule/issues/210. The default layoutBounds (which is what we design for) are based on the iPad aspect ratio so this shouldn't be happening. @jonathanolson is there some underlying common issue at play here?

For Collision Lab, I think we could shave some height off of the Momenta Diagram to get rid of the overlap.

jonathanolson commented 3 years ago

@jonathanolson is there some underlying common issue at play here?

I believe it's probably just that the font is a bit taller on that platform.

jonathanolson commented 3 years ago

I believe I've adjusted this so it should work nicely (no overlap when viewed on my iPhone).

KatieWoe commented 3 years ago

Quick check looks ok on master

KatieWoe commented 3 years ago

Looks good in 1.1.0 dev.13 iPadOS 14.3.