search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Small orbs can be hard to grab #192

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

For https://github.com/phetsims/QA/issues/594. Usability note. The mouse seems to be unable to grab the center of the balls (seen on several devices) and it seems like it might be due to the number. For the smallest radius, this can make grabbing them difficult and frustrating.

jonathanolson commented 3 years ago

I believe that should be fixed up by the above commit, can you verify?

KatieWoe commented 3 years ago

Seems fixed on the orbs, but I think the same thing may be happening with the velocity vectors where you can't grab where the letter v is.

jonathanolson commented 3 years ago

Can you verify that this is resolved in the above commit?

KatieWoe commented 3 years ago

That feels much better on master

DevonQui commented 3 years ago

The number on top of the orb no longer blocks user input but the part of the green vector arrow that overlays the orb still does. Besides that this issue can be closed. @jonathanolson can you confirm?

Screen Shot 2021-01-21 at 1 25 12 PM
KatieWoe commented 3 years ago

Good catch @DevonQui. Is there a way to make the ball grabbable under the green arrow without making the green arrow grabbable or changing the z ordering?

jonathanolson commented 3 years ago

I believe this was a consequence of the Accordion Box issue. In master and after that fix was applied, I believe this shouldn't be an issue. Can you verify master?

jonathanolson commented 3 years ago

Also applied a commit above that will ensure that if something comes up in the future, this should still work.

DevonQui commented 3 years ago

Tested this issue and neither the number text nor the green vector affect the user's ability to grab the balls. Closing