phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Constant size checkbox saving of state #193

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description Offshoot of https://github.com/phetsims/collision-lab/issues/183. Requested in https://github.com/phetsims/collision-lab/issues/183#issuecomment-757093430. The state should probably be changed when the constant size checkbox is checked or unchecked, as it changes when and where two orbs will bounce off each other meaning that stepping back past that point can lead to a slightly wrong history. This is less drastic than other instances of this wrong history, but it is still there. Interestingly, while stepping back with the step back button takes you past the change point, the blue restart button does take you to the point where the checkbox was checked.

Visuals constantsizeproblem

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Collision Lab‬ URL: https://phet-dev.colorado.edu/html/collision-lab/1.1.0-dev.13/phet/collision-lab_en_phet.html Version: 1.1.0-dev.13 2021-01-06 18:20:45 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.141 Safari/537.36 Language: en-US Window: 1280x658 Pixel Ratio: 1.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
arouinfar commented 3 years ago

Thanks @KatieWoe. That definitely looks a bit strange.

@jonathanolson would it be hard to add toggling the Constant Size checkbox to the laundry list of things that triggers a new saved state?

jonathanolson commented 3 years ago

I believe this should be handled with the above commit, can you verify?

KatieWoe commented 3 years ago

Looks good after a quick check on master

loganbraywork commented 3 years ago

Does not appear in https://github.com/phetsims/QA/issues/599