search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Multitouch dragging objects during reset can lead to unintended positions #204

Closed KatieWoe closed 3 years ago

KatieWoe commented 3 years ago

For https://github.com/phetsims/QA/issues/599. Fairly minor, feel free to close. If you are dragging something, such as a slider or ball, and press the reset all button at the same time, the object you were dragging is not dropped. multitouchmass

jonathanolson commented 3 years ago

Can you verify that the above commit fixes this?

KatieWoe commented 3 years ago

It now seems to freeze the sim with a console error.

simfreeze
jonathanolson commented 3 years ago

I'm not able to reproduce after spending a while on it (including setting timeouts to restart while dragging the slider, and I'm not seeing negative effects on iOS). Would it be possible to get some time on zoom where I could see this reproduced and briefly debug it?

KatieWoe commented 3 years ago

That sounds fine. I'll see if I can narrow it down too.

jonathanolson commented 3 years ago

I believe the above commit should resolve these issues (it does in my testing), can you verify?

KatieWoe commented 3 years ago

Issues I saw do look fixed on master

jonathanolson commented 3 years ago

Thanks!

KatieWoe commented 3 years ago

Looks good in rc.2