search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Checking constant size checkbox returns balls #206

Closed liammulh closed 3 years ago

liammulh commented 3 years ago

Test Device

iPad Pro

Operating System

iPadOS 14.4

Browser

Safari 14.0.3

Problem Description

For https://github.com/phetsims/QA/issues/607. If you check and uncheck the constant size checkbox on the intro screen, you'll see the balls magically return to the play area. See gif.

Gif

cl-issue

jonathanolson commented 3 years ago

This seemed partially expected, @arouinfar what should be the behavior here? This also applies if you manually change the mass.

arouinfar commented 3 years ago

@jonathanolson it seems weird to me that the balls are being bumped back into the play area when there isn't a reflecting border. Ideally, if there isn't a reflecting border nothing gets bumped.

jonathanolson commented 3 years ago

Ideally, if there isn't a reflecting border nothing gets bumped.

Is that a general preference for "we never bump a ball back into the play area when there is no reflecting border"?

arouinfar commented 3 years ago

Is that a general preference for "we never bump a ball back into the play area when there is no reflecting border"?

Yes

jonathanolson commented 3 years ago

Implemented with the above commit. NOTE: Leaving myself assigned for this, since I'll need to push the commit to the release branch before the next RC. (@jessegreenberg let me know when it's ready?)

jonathanolson commented 3 years ago

@liam-mulhall can you verify that this is fixed in master?

jonathanolson commented 3 years ago

Moved the commit to the 1.1 branch.

liammulh commented 3 years ago

Looks good on master.

loganbraywork commented 3 years ago

Seems to be fixed in Windows 10 Chrome and IPhone IOS14.4 Safari as of RC test https://github.com/phetsims/QA/issues/615