search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Convert to one of the ZoomButtonGroup subclasses #208

Open pixelzoom opened 3 years ago

pixelzoom commented 3 years ago

From https://github.com/phetsims/scenery-phet/issues/652, this sim is a candidate for converting to one of the ZoomButtonGroup subclasses. The Buttons screen of the scenery-phet demo shows the 2 subclasses (screenshot below), PlusMinusZoomButtonGroup on the left, MagnifyingGlassZoomButtonGroup. If you don't want to change the look of the sim, use MagnifyingGlassZoomButtonGroup. If you think the more modern-looking PlusMinusZoomButtonGroup is more appropriate, consult with your sim designer.

screenshot_882
pixelzoom commented 3 years ago

If there are questions about the model used by ZoomButtonGroup, these comments should be reviewed:

https://github.com/phetsims/scenery-phet/issues/652#issuecomment-778893088 https://github.com/phetsims/scenery-phet/issues/652#issuecomment-778912954 https://github.com/phetsims/scenery-phet/issues/652#issuecomment-778913045

arouinfar commented 3 years ago

@jonathanolson let's use this variety image

jonathanolson commented 3 years ago

This is one of those sims where it (a) supports fractional zooms for phet-io and (b) uses the multiplier approach mentioned in https://github.com/phetsims/scenery-phet/issues/652#issuecomment-778893088.

Since it's not currently compatible, I'm going to defer this (as suggested in https://github.com/phetsims/scenery-phet/issues/652#issuecomment-778912954).

jonathanolson commented 3 years ago

Common code will now allow this refactor.