search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Fonts in Collision Lab Arabic Translation #213

Closed issamali67 closed 3 years ago

issamali67 commented 3 years ago

@jbphet Fonts in the Arabic translation of Collision Lab appear smaller. Could live with that except for the "total" label appearing in the "Momenta Diagrams", it is too small in the Arabic. I have circled in red all the terms that need slightly larger fonts in Arabic (see attached). Also attached are the English counterparts.

CollisionLabEnglish CollisionLabArabic
jbphet commented 3 years ago

@issamali67 and I worked on this during a zoom call. The max width of the label for the "total" vector can be increased to help with that label, so I've done so. The radio buttons that control the sim speed are a different story. These appear a bit small because of the font size, not the max width, and @issamali67 said we should just leave them.

jbphet commented 3 years ago

@jonathanolson - I just cherry-picked a small commit onto the active release branch for this sim. Can I maintenance release it or is there an active maintenance release that this would be bundled with?

jonathanolson commented 3 years ago

No active maintenance stuff on my end, feel free to cherry-pick or RC whenever.

jbphet commented 3 years ago

The maintenance release with this change is complete. The version is 1.1.2.

The difference isn't huge, but it's noticeable. Here are some screenshots, and notice that the label on the black arrow is now larger.

Before: image

After: image

@issamali67 - Please have a look at the published version and, if it looks like our intended change was correctly published, please close this issue.

issamali67 commented 3 years ago

Looks good. Will close the issue.

On Fri, Jul 2, 2021 at 2:38 PM John B @.***> wrote:

Assigned #213 https://github.com/phetsims/collision-lab/issues/213 to @issamali67 https://github.com/issamali67.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/phetsims/collision-lab/issues/213#event-4973207951, or unsubscribe https://github.com/notifications/unsubscribe-auth/APO5ENKLCY35LE5I6Z2W4XLTVYPUPANCNFSM46XXGHCQ .