search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

rename Path.js #79

Closed pixelzoom closed 4 years ago

pixelzoom commented 4 years ago

The name of collision-lab/Path.js collides with scenery/Path.js. And the former is unfortunately the first choice for auto-import in WebStorm, which results in recurring import errors. Could we please rename collision-lab/Path.js ?

brandonLi8 commented 4 years ago

@pixelzoom do you have a proposal for a better name? The path shows up in the control panel image

and I believe we typically keep the naming consistent.

brandonLi8 commented 4 years ago

The auto-importing on sublime also allows you to choose the correct version if their are name clashes.

brandonLi8 commented 4 years ago

I guess i suppose I could rename it so something like Trace, but it seems weird to have traceVisibleProperty passed to the pathCheckbox. Unless the Path checkbox is changed to a Trace checkbox, which I believe would be unlikely.

pixelzoom commented 4 years ago

A common convention is to add a prefix when there's a name collision with common code. So how about CollisionLabPath ?

brandonLi8 commented 4 years ago

Ok. Renamed Path to CollisionLabPath. Closing.