search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Position Keypad #89

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

From the dust-off meeting @arouinfar and I had, there were two options that were presented for positioning the keypad; either above the BallValuesPanel or to the right of the BallValuesPanel.

There wasn't a decision made, so this issue is here to track this.

brandonLi8 commented 4 years ago

Looks like there was a decision made on 9/19/2019: "Keypad will appear to the [right] of the panel, and would obscure the Momenta diagram, if open."

Doing this now.

brandonLi8 commented 4 years ago

In the commit above, I attempted to position the keypad correctly.

However, expanding more-data and popping up the dialog doesn't reposition the keypad, and only does so when you close it and resize the browser window. Making an issue in sun.

brandonLi8 commented 4 years ago

Now that phetsims/sun#600 is done, the keypad is now positioned to the right of the BallValuesPanel with the same margin for both the More Data on and off. Keep in mind the y-position of the Keypad changes based on the height of the panel (bottom aligned). image

@arouinfar this is ready for review in master.

arouinfar commented 4 years ago

@brandonLi8 the keypad placement and alignment look really good in master. Nice work!