search

phetsims / collision-lab

"Collision Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
6 stars 4 forks source link

Aspect ratio of the Pool Tables #99

Closed brandonLi8 closed 4 years ago

brandonLi8 commented 4 years ago

A while back, the aspect ratio of the pool tables was discussed here. It doesn't look a decision was made, so I'm making this issue.

Currently, the grid is 8x4 for explore 2D and 8x2 for 1D screens. I'd also like to note that we should probably keep the dimensions even so the origin is in the center.

Also, in the mockups, the grid for explore 2D is 8 blocks long but 9 blocks long for 1D screens. Unsure if this is intentional.

Edit: I would also like to mention that we have more vertical space now that there are only 4 balls maximum since the BallValuesPanel's has a smaller height.

arouinfar commented 4 years ago

@brandonLi8 I reviewed master, and I think the current size and aspect ratio of the 2D grid looks good. Let's continue with the 8x4 grid so the origin is centered.

For 1D, it would be really nice if we could have a 2x9 grid. Tagging for design meeting for discussion.

arouinfar commented 4 years ago

On second thought, the origin centering would be an issue for the 2x9 grid.

Keeping this tagged for design meeting so the team is aware.

brandonLi8 commented 4 years ago

Spoke with @arouinfar on 6/25/20, and we decided to leave the aspect ratio as-is on master. Closing.