search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

bad use of options in RGBPhotonBeamNode #101

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

In RGBPhotonBeamNode constructor:

@param {Object} [options] (must contain a field canvasBounds to indicate the bounds of the beam)

If options must contain canvasBounds, then it's not optional, and should be a required constructor parameter.

pixelzoom commented 8 years ago

RGBPhotonBeamNode extends CanvasNode, and this is the same API used by CanvasNode. So I'm going to leave this as is. Closing.