search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Are wavelengths really expressed in units of wavelengths? #108

Closed andrewadare closed 7 years ago

andrewadare commented 7 years ago

While instrumenting Color Vision for phet-io, I came across these lines in SingleBulbModel.js:

flashlightWavelength: 570,   // in units of wavelengths, default wavelength is yellow color
filterWavelength: 570,       // in units of wavelengths, default wavelength is yellow color

I need to specify units for these variables (see https://github.com/phetsims/phet-io/issues/540#issuecomment-239199991) and although I'm not familiar with the sim at all, these comments look incorrect (or at least surprising).