search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

failing lint due to PHET_IO #112

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

color-vision is failing lint, looks like a PHET_IO issue:

grunt lint
Running "eslint:repoFiles" (eslint) task

/Users/cmalley/PhET/GitHub/color-vision/js/rgb/model/RGBModel.js
  24:3  error  PHET_IO require must start with an ifphetio! check.   phetio-require-contains-ifphetio

/Users/cmalley/PhET/GitHub/color-vision/js/singlebulb/model/SingleBulbModel.js
  26:3  error  PHET_IO require must start with an ifphetio! check.   phetio-require-contains-ifphetio

✖ 2 problems (2 errors, 0 warnings)

Warning: Task "eslint:repoFiles" failed. Use --force to continue.

Aborted due to warnings.
pixelzoom commented 7 years ago

Fixed. @andrewadare looks like you added this require statement awhile ago. Perhaps something changed recently in for how PHET_IO require statement are validated? Please review and close if this looks good.

andrewadare commented 7 years ago

Thanks for fixing @pixelzoom, sorry I didn't run the linter to catch these.