phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

model base type needed #117

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

Noted while working on conversion from PropertySet to Property (https://github.com/phetsims/color-vision/issues/116).

RGBModel and SingleBulbModel contain duplicate Properties - playingProperty and headModeProperty. They both define function manualStep. All of these things are used by ColorVisionScreenView, the base type for both the RGB and Single-Bulb views. So there should be a base type for the model, ColorVisionModel, that defines the API usable by ColorVisionScreenView and its subtypes.