search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

clean up IO types #119

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

Similar to https://github.com/phetsims/beers-law-lab/issues/222

pixelzoom commented 6 years ago

In addition to the usual missing type expressions...

SingleBulbPhotonBeamIO.js looks like it has a copy-paste error from beers-law-lab:

45 * Adds a precipitate particle as specified by the phetioID and state.

pixelzoom commented 6 years ago

As with https://github.com/phetsims/beers-law-lab/issues/222, I cleaned up the IO types, but was unable to test because of phetsims/joist#469. Assigning to @samreid to review and test.

samreid commented 6 years ago

The changes look good, closing.