phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

incomplete implementation of SingleBulbPhotonBeamIO #120

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

This looks like trouble in SingleBulbPhotonBeamIO:

    /**
     * Serializes an instance.
     * @returns {Object}
     */
    toStateObject: function() {
      return {};
    },

    /**
     * Deserializes an instance.
     * @returns {}
     */
    fromStateObject: function() {
      return {};
    },

    /**
     */
    setValue: function() {
    }
samreid commented 6 years ago

It looks like those methods are not necessary, we can opt out of the state altogether and still be a container for addChildInstance, fixed in preceding commit. @pixelzoom would you like to review? Close if all is well.