search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

[1.2.5-rc.1-phetio] [State Wrapper] color not the same in second iframe #125

Open JRomero0613 opened 6 years ago

JRomero0613 commented 6 years ago

Test Device: PC Laptop

OS: Windows 10 v. 1803

Browser: Google Chrome v. 67.0.3396.79

Problem description: For phetsims/QA#128 when using the state wrapper with color version v. 1.2.5-rc.1-phetio the translated sim does not show the proper color of light the person sees on the single bulb screen. This bug occurs in both the previous version of the sim, and master.

Reproduce steps:

  1. Open the sim with the state wrapper and navigate to the single bulb screen.
  2. Change the light to white
  3. Change the light style to particle
  4. Turn both the light and filter on
  5. Change the filter color, the color perceived by the observer in the sim will not change in the smaller sim

Screenshots: color_vision_state

Here is the error that appears in the console:


TypeError: Cannot read property 'constructor' of undefined
    at Object.getType (color-vision_en-phetio.html?production:965)
    at Object.g [as setState] (color-vision_en-phetio.html?production:965)
    at TPhETIO.implementation [as setState] (color-vision_en-phetio.html?production:990)
    at Object.invoke (color-vision_en-phetio.html?production:990)
    at Object.handleRequest (color-vision_en-phetio.html?production:990)
    at color-vision_en-phetio.html?production:990
zepumph commented 6 years ago

Thanks for the error report. Good to know that it doesn't work in master. Unassigning until we work on this sim again. Tagging @samreid so he is aware.

phet-steele commented 6 years ago

Duplicate of #118, but both have important info. So closing #118 and quoting it:

From phetsims/phet-io#374 The file is missing colorVision.singleBulbScreen.model.perceivedColor. A consequence of this is that the perceived color on this screen is not saved in the state of the sim, and therefore not loaded from the state wrapper's URL. There may be other things missing from this file, but I didn't take the time to check. For phetsims/tasks#532.

Luisav1 commented 5 months ago

Deferring this issue since we're not going to republish with PhET-iO for the upcoming publication.