search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

CT: should have type: SingleBulbPhotonIO in allTypes #132

Open pixelzoom opened 4 years ago

pixelzoom commented 4 years ago

Similar to https://github.com/phetsims/beers-law-lab/issues/244. This longstanding problem was apparently revealed when Studio started running on CT again recently. The solution is to port dynamic SingleBulbPhoton to use PhetioGroup.

color-vision : phet-io-studio-fuzz : require.js : run
Uncaught Error: should have type: SingleBulbPhotonIO in allTypes. May need grunt update?
Error: should have type: SingleBulbPhotonIO in allTypes. May need grunt update?
    at window.assert (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/phet-io-wrappers/common/js/assert.js:32:13)
    at getCreator (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/StudioInstanceCreator.js:778:15)
    at StudioInstanceCreator.createStudioInstance (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/StudioInstanceCreator.js:61:26)
    at Studio.onPhetioElementAdded (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/Studio.js:276:63)
    at phetioElementAdded (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/studio/js/main.js:50:26)
    at Client.dispatch (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/phet-io-wrappers/common/js/Client.js:452:56)
    at windowMessageListener (https://bayes.colorado.edu/continuous-testing/snapshot-1582032248597/phet-io-wrappers/common/js/Client.js:341:24)
id: Bayes Chrome
Approximately 2/18/2020, 6:24:08 AM
pixelzoom commented 4 years ago

Before working on this issue, verify that individual photons really need to be instrumented. Don't make the same mistake that was apparently made in https://github.com/phetsims/beers-law-lab/issues/244#issuecomment-598472966.

Luisav1 commented 2 months ago

Deferring this issue since we're not going to republish with PhET-iO for the upcoming publication.