search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Use PhetioGroup #134

Open zepumph opened 4 years ago

zepumph commented 4 years ago

From https://github.com/phetsims/color-vision/issues/127 and https://github.com/phetsims/tandem/issues/87

This may not take too long, and would be good cleanup. Assigning to @chrisklus.

zepumph commented 3 years ago

Note that over in https://github.com/phetsims/tandem/issues/87 the old pattern was removed (https://github.com/phetsims/color-vision/commit/710cd36d7507a803c292ece4abeff58991c779e9 and https://github.com/phetsims/color-vision/commit/d43eea20cb78de5098c8d96f09314fff9e1fb8b6), but no new pattern was added. This work should be done as part of #127.

samreid commented 3 years ago

It was unclear that the photons need to be instrumented, we can decide when we revisit this simulation for phet-io.

Luisav1 commented 2 months ago

Deferring this issue since we're not going to republish with PhET-iO for the upcoming publication.