phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Add labels to flashlights and sliders (RGB screen) #152

Closed amanda-phet closed 1 week ago

amanda-phet commented 1 month ago

From https://github.com/phetsims/color-vision/issues/148 we decided to make the following updates to this sim:

image

Luisav1 commented 2 weeks ago

@amanda-phet I have updated the sim and this is what it looks like now: image Could you review it to ensure everything is looking good? Thanks!

amanda-phet commented 2 weeks ago

The labels look good to me, although the Blue label background doesn't look "centered" on the handle. Can that be moved "down" slightly on the flashlight handle?

I'm also not sure about the tick marks.. they don't look connected to the slider track. Is there anything we can do about that? I'm not very familiar with sliders, but that's my first impression. I think it's because the slider track has a black stroke around it, so I would play with also giving the tick marks a black stroke if that's possible.

Luisav1 commented 2 weeks ago

Thank you for the review! I moved the blue label down slightly: image

On the customizing options for tick marks, they are unfortunately limited in the SliderTick class. Currently, you can only adjust the tick's length, width, and color.

I tested with setting the track stroke color to white: image

Also, I tried making both the stroke color white and reducing the track width: image

@amanda-phet, do you have any preference or suggestions?

amanda-phet commented 1 week ago

I got some feedback on this design and the consensus is we like the third one, which is all white and a thinner track.

Luisav1 commented 1 week ago

Thanks @amanda-phet! I've applied those changes and this is how it looks like now: image This issue is ready to be closed.