search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Photons don't have constant speed #19

Closed aaronsamuel137 closed 10 years ago

aaronsamuel137 commented 10 years ago

The x-velocity of the photons is constant, but the y-velocity varies slightly randomly to implement the fanning. Is it important that photons all move at a constant speed?

aaronsamuel137 commented 10 years ago

Its easy to change the photons to move at a constant speed, but it is creating a new bug where small gaps appear in the photon stream. I'm not sure how long it would take me to debug it, maybe an hour or two. Probably easier just to leave the x-velocity constant instead of the speed, but I'm happy to change this if you think its important. Assigning to @ariel-phet for feedback.

ariel-phet commented 10 years ago

Hey @aaronsamuel137, I think you can revert to the constant x-velocity, my eye does not pick up that the photons are moving at speeds that are not constant, so the visualization is doing its job even if it is not perfect.Please make a note in the Color Vision design document that explains this fine point about the model being used.

aaronsamuel137 commented 10 years ago

Made the following note in the design doc and code comments:

Note: The photons in color vision move at a constant x-velocity, not a constant speed. The y-velocity varies only slightly to accommodate the fanning of the photons, so it is not really discernible when looking at the simulation.

aaronsamuel137 commented 10 years ago

Closing.