search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Images generally shouldn't contain padding #21

Closed samreid closed 10 years ago

samreid commented 10 years ago

Images like "color-vision-white-light-icon.png" shouldn't contain extra padding--the padding should be added in the code. Please use an image editing utility to remove the extra transparent padding or request the artist to provide new images that doesn't contain the blank padding. This will give us more control in the code over margins and layout.

aaronsamuel137 commented 10 years ago

Would you recommend clipping all extra whitespace outside of a rectangle containing icon, or keeping the same aspect ratio for all icons? For instance, the beam icons have a different aspect ratio than the light bulbs, so removing all padding would require adding a different amount of padding for each icon in the code, as opposed to the same padding parameters for all the icons.

samreid commented 10 years ago

Good point! Padding is appropriate to use when keeping images/icon layouts the same for the reason you mentioned.

aaronsamuel137 commented 10 years ago

Sounds good, I'll proceed with keeping the same aspect ratio for all icons.

aaronsamuel137 commented 10 years ago

Done. There is now a slight gap between the edge of the flashlight neck and icon border caused by the padding. It looks fine to me, but want to get some other opinions.

samreid commented 10 years ago

There is now a slight gap between the edge of the flashlight neck and icon border caused by the padding. It looks fine to me, but want to get some other opinions.

I'm not sure exactly what you're referring to. Can you clarify?

aaronsamuel137 commented 10 years ago

There is a slight gap between the outline and the flashlight neck, caused by adding the padding, that wasn't there before. Hope the picture clarifies, otherwise I'll show you next time we meet.

beamicons

samreid commented 10 years ago

That may be fine. If others think it looks odd, we could make it so the flashlight icons are the same size as each other, but a different size than the light bulb icons (which match each other).

samreid commented 10 years ago

Reassigning to @aaronsamuel137 to discuss with @ariel-phet and/or @gruneich.

aaronsamuel137 commented 10 years ago

Closing for now. We can reopen if this gets brought up by the design team.