search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Move constants out of top level file #29

Closed samreid closed 10 years ago

samreid commented 10 years ago

It looks like many constants don't apply to both screens of the sim. Please move the constants to the appropriate folder.

aaronsamuel137 commented 10 years ago

First I tried to put constants in the RGBScreen and SingleBulbScreen files, but was getting strange requirejs errors, so I ended up just creating new files for them. Assigning to @samreid for review

samreid commented 10 years ago

That sounds good, I skimmed the change set and looks good too, thanks! Closing.