search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

External code review #32

Closed samreid closed 10 years ago

samreid commented 10 years ago

@aaronsamuel137 is the lead developer for this sim, and I have been reviewing the code intermittently as it has been developed. Still, since @aaronsamuel137 and I have been working together closely, it seems like we do not have significantly different perspectives and I think it would be beneficial for another developer such as @jonathanolson @pixelzoom or @jbphet to do an external review.

pixelzoom commented 10 years ago

I'll do it.

pixelzoom commented 10 years ago

@aaronsamuel137, please let me know when you're ready to have me do a review. I recommend doing a final pass yourself first to clean up anything you might have missed. Thanks.

aaronsamuel137 commented 10 years ago

Thanks a lot @pixelzoom. I'll let you know when I am ready. I'll do a final pass and wait until @samreid closes any outstanding issues he started.

samreid commented 10 years ago

I reviewed and closed or reassigned all of the issues assigned to me. So I'll reassign this to @aaronsamuel137 to do a final pass and assign to @pixelzoom when ready.

aaronsamuel137 commented 10 years ago

I've finished my pass. Assigning to @pixelzoom. Thanks!

pixelzoom commented 10 years ago

Sorry I missed the github notification on this one. I will complete this before Aug 1.

pixelzoom commented 10 years ago

Code review completed. I created issues labeled 'code-review'. Let me know if you have any questions.

aaronsamuel137 commented 10 years ago

Everything looks good to me, thanks for a thorough review! I have assigned everything I have questions about back to you for review.

aaronsamuel137 commented 10 years ago

I've addressed all review issues. Closing.