search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

JSDoc types incorrect in IconToggleNode #35

Closed samreid closed 10 years ago

samreid commented 10 years ago

It looks like the JSDoc for IconToggleNode constructor may be wrong. I think Image should be Node. If so, please change it.

aaronsamuel137 commented 10 years ago

I think your right. It was Image because that is the kind of node I was passing to it when using it in color-vision, but there is not reason why it shouldn't be able to take a more general kind of node. I have changed it to Node. Assigning to @samreid for review

samreid commented 10 years ago

Looks great, thanks! Closing.