search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

review issues #36

Closed samreid closed 10 years ago

samreid commented 10 years ago

I'm going to make some minor code changes. I created this issue so they will be aggregated here for ease of review.

samreid commented 10 years ago

I've finished my commits above, please review them to (a) make sure they look good and (b) see if the same patterns should apply elsewhere. Please let me know if you have any questions about the changes. Close if everything looks good.

aaronsamuel137 commented 10 years ago

Everything looks pretty good to me. Is there a specific guideline followed in the codebase around empty lines before comments? Looks like all the empty lines you added were before multiline comments.

samreid commented 10 years ago

We haven't standardized on blank lines before line comments as a team. I prefer to add the blank line before line comments but don't feel too strongly. Maybe we should briefly discuss on Thursday?

samreid commented 10 years ago

We discussed blank lines before line comments today and decided not to standardize on a convention, but just to do what seems appropriate in each case.

aaronsamuel137 commented 10 years ago

Sounds good. All changes here look good to me. Closing