SingleBulbPhotonBeam.updateAnimationFrame and reset are defined elsewhere.

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/color-vision

GNU General Public License v3.0

1 stars 7 forks source link

SingleBulbPhotonBeam.updateAnimationFrame and reset are defined elsewhere. #40

Closed samreid closed 10 years ago

samreid commented 10 years ago

SingleBulbPhotonBeam.updateAnimationFrame and reset are defined outside of the inherit call. I was wondering if they should be inlined in the inherit call, as we do elsewhere throughout the sim.

aaronsamuel137 commented 10 years ago

I think this is a good idea. I applied the same pattern in RGBPhotonBeam too. Assigning to @samreid for review.

samreid commented 10 years ago

Looks good, thanks! Closing.