phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Support options in GaussianWavelengthSlider #41

Closed samreid closed 10 years ago

samreid commented 10 years ago

GaussianWavelengthSlider is created like so:

    // Create gaussian wavelength slider
    var gaussianSlider = new GaussianWavelengthSlider( model.filterWavelengthProperty, SLIDER_TRACK_WIDTH, SLIDER_TRACK_HEIGHT );
    gaussianSlider.bottom = this.layoutBounds.bottom - 20;
    gaussianSlider.right = wavelengthSliderDistance;

What do you think about adding an options parameter to the GaussianWavelengthConstructor so the layout can be passed in through the options?

aaronsamuel137 commented 10 years ago

I think that's a great idea. Assigning to @samreid for review.

samreid commented 10 years ago

Looks good, thanks! Closing.