search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

no assets directory #55

Closed pixelzoom closed 10 years ago

pixelzoom commented 10 years ago

The original graphics files (typically Adobe Illustrator files) for all images should be in the assets/ subdirectory of the repository. Anytime you get an image from someone, also ask for the original asset and check it in. This allows us to easily locate and modify files in the future.

aaronsamuel137 commented 10 years ago

I asked Ariel and Oliver about this and these are the files they gave me. Let me know if it looks like what you expected. Assigning to @pixelzoom for review

pixelzoom commented 10 years ago

A few problems...

Color Vision Artwork.ai - Does not reflect the current state of the sim. The head looks totally different now, and I don't see and asst that reflects that. As noted in the issue description above: Anytime you get an image from someone, also ask for the original asset and check it in.

Color Vision HTML5.ai - This file appears to be empty (or locked?) when I try to open it with applications that are usually able to open Illustrator files (e.g., Preview, Inkscape). Does this file actually contain anything?

color-vision-screenshot-1.png - The screenshot should be named color-vision-screenshot-128.png, and this screenshot appears to be obsolete (doesn't look like the current version of the sim).

In general, it will make life easier for future maintainers if there are separate asset files for the various pieces of artwork. I would therefore expect to see individual asset files for: head, flashlight, brain. I currently see the brain, head (obsolete, and in a file that's not named 'head'), and I see no flashlight.

aaronsamuel137 commented 10 years ago

@ariel-phet Could you have Mike send me the .ai files for the new head(s) when they are ready, or just commit them to the assets directory? Thanks

ariel-phet commented 10 years ago

Will do...might be a couple of days.

pixelzoom commented 10 years ago

Does anyone have ideas about how to make this general problem go away? How to encourage artists and developers to get in the habit of including an 'asset' file for each image used in sims?

aaronsamuel137 commented 10 years ago

I've cleaned up the assets directory and gotten rid of the unused assets. There's three illustrator files now, should I try to combine them? Assigning to @pixelzoom for review.

pixelzoom commented 10 years ago

Looks like everything is there now. Closing.