phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

port Java string files #56

Closed pixelzoom closed 10 years ago

pixelzoom commented 10 years ago

There is a Java utility for converting the Java string files (.properties) to HTML5 string files (.json). See chipper.PropertiesToJSON.java.

Careful when you run this -- it will overwrite your English string file, which you may not want to do at this point. Simply revert the English string file before checking in.

aaronsamuel137 commented 10 years ago

Done. There are two issues to resolve here.

  1. Previously I was using "RGB" for the name of the RGB screen, whereas the Java version uses "RGB Bulbs". We could either update every file to use "RGB" instead, or stick with the original version using "RGB Bulbs". Not sure which is better here.
  2. There are many string fields that are no longer used in this version of color-vision. Should I delete these?
aaronsamuel137 commented 10 years ago

Assigning to @pixelzoom for review.

pixelzoom commented 10 years ago

There are two issues to resolve here.

  1. There is no need to change the "RGB" title string in the translation files.
  2. There is no need to remove obsolete strings from the translation files.

We will eventually be asking translators to update their translations. At that time, they can correct and strings that PhET has changed. And the translation tool will present (and save) only strings that are present in the English string file.