search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Unused code in FlashlightNode #6

Closed samreid closed 10 years ago

samreid commented 10 years ago

This line of code isn't used in flashlightnode, and refers to an undefined this.options:

    options = _.extend( this.options, options );
aaronsamuel137 commented 10 years ago

Good catch. I was thinking of trying to use options, but then decided against it. Might need to tweak this class a bit more the future once I figure out exactly how I want to do it

Assigning to @samreid for review

samreid commented 10 years ago

Looks good, thanks! Closing.