Add rectangle around wavelength sliders like in RGB screen.

[samreid]

To clarify, I think the rectangle should just be around the spectrum, not around the slider knob.

[aaronsamuel137]

Alright I have added these rectangles, let me know what you think. I expect they'll need some design tweaking. Assigning to @samreid for review.

[samreid]

In my opinion, these rectangles are a bit overwhelming. I was envisioning a thin (around 1px) gray stroke around the spectrum to exactly match the thin gray borders around the gradient sliders in the "RGB screen".

It looks like you made them larger and shinier to make them more consistent with the extra "chrome" on the screen. Perhaps it does make things more consistent on this screen, but a bit busier. Perhaps we should get @ariel-phet's opinion too before making changes?

[aaronsamuel137]

Sounds good, I'll ask him what he thinks. Were you envisioning the rounded corners like RGBScreen too, or just the thin gray outline?

[samreid]

Based on the current implementation of the spectrum it may be more difficult to do the rounded corners. In my opinion the main point is just to add a thin separation between the spectrum and the black background, so perhaps a square rectangle would be okay.

[aaronsamuel137]

Something like this?

Without rounded corners:

With slightly rounded corners:

[ariel-phet]

Yes, something like the above...without rounded corners. Just that thin white line.

[aaronsamuel137]

OK, I have made this change. Note, you'll need to pull scenery-phet too since it relies on changes to WavelengthSlider. Assigning to @ariel-phet for review.

[ariel-phet]

Looking good.