search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

aliasing of the lines on the "tilted" flashlights #85

Closed bryo5363 closed 3 months ago

bryo5363 commented 9 years ago

Observed on Windows 8 IE 11.0.9600.17239

screenshot 3

bryo5363 commented 9 years ago

I happened to notice this on all of the home screens I have tested so far, not just on iFrame so I renamed the issue.

bryo5363 commented 9 years ago

Chrome 37.0.2062.120 on OS X 10.9.4: screen shot 2014-09-16 at 11 42 12 am

Safari 7.0.5: screen shot 2014-09-16 at 11 42 44 am

ariel-phet commented 9 years ago

Hey @bryo5363 do you mean the aliasing of the lines on the "tilted" flashlights?

bryo5363 commented 9 years ago

@ariel-phet yes, I did not know how to phrase it adequately.

ariel-phet commented 9 years ago

This seems like a candidate for mipmapping next time we republish the sim (which will be necessary for translations and such)

pixelzoom commented 5 years ago

The flashlights should be drawn programmatically, taking care to make lighting (gradient) consistent with rotation.

Luisav1 commented 3 months ago

The flashlight is now drawn problematically in FlashlightNode with the gradient remaining horizontal whenever that flashlight rotates: image

I did this to follow the flashlight's and their gradients as in the RGB screen: image

The aliasing is no longer present as a result of this.