search

phetsims / color-vision

"Color Vision" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/color-vision
GNU General Public License v3.0
1 stars 7 forks source link

Add JSDoc parameters #9

Closed samreid closed 10 years ago

samreid commented 10 years ago

Some JSDoc documents some but not all parameters. Would be good to have all parameters documented. For instance, PhotonBeam.js has:

  /**
   * @param {Color} color
   */
  function PhotonBeam( color, intensityProperty, perceivedIntensityProperty, size ) {
aaronsamuel137 commented 10 years ago

I did my best to follow conventions I have seen elsewhere, but its very possible I missed something, so let me know if you catch any inconsistencies

Assigning to @samreid for review

samreid commented 10 years ago

Looks much better, thanks! Closing.